feat: Nautobot operator #1425
Closed
feat: Nautobot operator #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
reviewed
Nov 25, 2025
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
Overall the change is good but too big to really review line by line or file by file. Let's rebase this and get it running in the dev environment and see it in action.
How do we define the CRD? From an object or by writing the YAML? I think we'll need to update the deployment docs around this going forward as well.
When neutron starts up it is cleaning up OVN and it might take some extra time to be ready so increase the amount of time.
This was pinned only for macOS testing of the code base and not an actual runtime dependency so remove it to avoid version conflicts in the actual deployed code.
If we are able to read the physical_network from the port binding information then we should do that over looking it up. Uses: https://review.opendev.org/c/openstack/ironic/+/964570
Switched to using more of a two part build in the containers to install everything in the build layer and then copy it into the runtime container to shrink them further. Switch to using uv exclusively to make it consistent with the build tooling we use. Add the OpenStack constraint file to ensure we do not upgrade to too new of a version when installing additional dependencies.
The version of sushy that our current version of Ironic (2025.2) depends on and is included in our container has sushy-oem-idrac included in it and the Ironic code base will use it over sushy-oem-idrac. So there is no point in installing this.
Contributor
Author
|
Closing this one and created new one, because of branch diverged a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing this one, created new one #1459